Skip to content

[quality] ratchet up 10 stale Go coverage baselines to actual values#19761

Merged
clubanderson merged 1 commit into
mainfrom
quality/ratchet-stale-baselines
Jun 29, 2026
Merged

[quality] ratchet up 10 stale Go coverage baselines to actual values#19761
clubanderson merged 1 commit into
mainfrom
quality/ratchet-stale-baselines

Conversation

@kubestellar-hive

@kubestellar-hive kubestellar-hive Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Test Improvement

Ratchets up 28 stale Go coverage baselines to actual measured values. Many packages were at 100% coverage but the ratchet file listed 0-75%, allowing silent regressions.

Key corrections

  • 6 supporting packages at 100% listed as 0-95%
  • 10 compliance packages at 100% listed as 55-75%
  • 12 additional packages ratcheted to current levels

All values verified via go test -cover.

Filed by quality agent (hold-gated mode). Human review required.

Copilot AI review requested due to automatic review settings June 26, 2026 23:51
Copilot AI reviewed Jun 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot can't review bot-authored pull requests automatically. A user with Copilot access can request a review manually.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jun 26, 2026
@kubestellar-prow

kubestellar-prow Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit bb2a4fc
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a42a8bea9c3cf000865bd19
😎 Deploy Preview https://deploy-preview-19761.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubestellar-hive kubestellar-hive Bot added hold Blocked — do not touch quality testing labels Jun 26, 2026
@github-actions github-actions Bot added the ai-generated Pull request generated by AI label Jun 26, 2026
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 26, 2026
@kubestellar-hive kubestellar-hive Bot force-pushed the quality/ratchet-stale-baselines branch from 101277f to 5567001 Compare June 27, 2026 01:50
@kubestellar-prow kubestellar-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 27, 2026
@kubestellar-hive kubestellar-hive Bot force-pushed the quality/ratchet-stale-baselines branch 9 times, most recently from d17325c to da96703 Compare June 28, 2026 02:12
ZachDreamZ
ZachDreamZ approved these changes Jun 28, 2026
View reviewed changes

@ZachDreamZ ZachDreamZ left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data-only change to coverage ratchet file. No code risk. One note: 12 of 16 compliance packages jump to exactly 100.0 which is unusual. Worth spot-checking a couple with go test -cover to confirm these aren't measurement artifacts (e.g. packages with no testable code reporting 100%). Otherwise LGTM.

@kubestellar-prow

kubestellar-prow Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

@ZachDreamZ: changing LGTM is restricted to collaborators

Details

In response to this:

Data-only change to coverage ratchet file. No code risk. One note: 12 of 16 compliance packages jump to exactly 100.0 which is unusual. Worth spot-checking a couple with go test -cover to confirm these aren't measurement artifacts (e.g. packages with no testable code reporting 100%). Otherwise LGTM.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-hive kubestellar-hive Bot force-pushed the quality/ratchet-stale-baselines branch 4 times, most recently from c8cb830 to c69afc9 Compare June 28, 2026 12:22
@kubestellar-hive kubestellar-hive Bot force-pushed the quality/ratchet-stale-baselines branch 12 times, most recently from e80f76b to 42170f6 Compare June 29, 2026 14:51
@clubanderson clubanderson force-pushed the quality/ratchet-stale-baselines branch from 42170f6 to 9a9c82a Compare June 29, 2026 16:22
@clubanderson
[quality] ratchet up 28 stale Go coverage baselines to actual values
bb2a4fc 
Updates go-package-coverage-ratchet.txt to reflect actual measured
coverage. Many packages had significantly outdated baselines:

Supporting packages (12 updates):
- pkg/ai: 0.0 → 100.0
- pkg/models: 0.0 → 100.0
- pkg/safego: 65.0 → 100.0
- pkg/stellar: 80.0 → 100.0
- pkg/sanitize: 85.0 → 100.0
- pkg/rewards: 95.0 → 100.0
- pkg/notifications: 75.0 → 78.5
- pkg/watcher: 67.1 → 72.8
- pkg/settings: 75.0 → 77.1
- pkg/kagent: 85.0 → 86.2
- pkg/mcp: 65.0 → 67.2
- pkg/fileutil: 50.0 → 54.2

Compliance packages (16 updates):
- 10 packages at 100.0% (were 55-75%): fedramp, hipaa, nist80053,
  slsa, sbom, signing, licenses, stig, baa, airgap, frameworks, reports
- pkg/gxp: 60.0 → 98.0
- pkg/changecontrol: 60.0 → 95.3
- pkg/sod: 60.0 → 88.5
- pkg/residency: 65.0 → 85.5

Stale baselines defeat the purpose of ratcheting — coverage can
silently regress back to the old floor without triggering a failure.

Signed-off-by: Quality Agent <quality-agent@kubestellar.io>
@clubanderson clubanderson force-pushed the quality/ratchet-stale-baselines branch from 9a9c82a to bb2a4fc Compare June 29, 2026 17:17
@clubanderson clubanderson merged commit c8244d3 into main Jun 29, 2026
15 of 18 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the quality/ratchet-stale-baselines branch June 29, 2026 17:34
@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit c8244d38a07d967bd38a2157325ea5284c18baa0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
+1 more reviewer
@ZachDreamZ ZachDreamZ ZachDreamZ approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ai-generated Pull request generated by AI dco-signoff: yes Indicates the PR's author has signed the DCO. hold Blocked — do not touch quality size/M Denotes a PR that changes 30-99 lines, ignoring generated files. testing tier/2-standard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZachDreamZ @clubanderson